Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit events #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Emit events #92

wants to merge 1 commit into from

Conversation

getkey
Copy link

@getkey getkey commented Jan 13, 2017

Currently we need to assign a function to DataChannel or PeerConnection instances' on-something properties (eg onicecandidate).
It is nicer to let the user register listeners.

@getkey getkey mentioned this pull request Feb 7, 2017
Open
@getkey getkey mentioned this pull request Feb 23, 2017
Closed
@getkey
Copy link
Author

getkey commented Feb 26, 2017

I published the NPM package electron-webrtc-patched because I need the changes in this PR.
I will take it down if my PRs are accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@getkey